Skip to content

useless_if_let_seq should not warn for composite ifs #1089

Closed
@Manishearth

Description

@Manishearth

It warns on:

    let mut bubble_inline_sizes_separately = debug_options.bubble_widths;
    if debug_options.trace_layout {
        paint_threads = 1;
        layout_threads = 1;
        bubble_inline_sizes_separately = true;
    }

While this could be rewritten, I'm not sure if it should.

Additionally, we shouldn't use span_suggestion here since the suggestion isn't valid rust code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: Clippy is not doing the correct thingI-false-positiveIssue: The lint was triggered on code it shouldn't have

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions