Skip to content

Commit 4617fea

Browse files
committed
redundant_field_names: Do not trigger on path with type params
Fixes #3476
1 parent 7dac0ed commit 4617fea

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

clippy_lints/src/redundant_field_names.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ impl EarlyLintPass for RedundantFieldNames {
5757
continue;
5858
}
5959
if let ExprKind::Path(None, path) = &field.expr.node {
60-
if path.segments.len() == 1 && path.segments[0].ident == field.ident {
60+
if path.segments.len() == 1
61+
&& path.segments[0].ident == field.ident
62+
&& path.segments[0].args.is_none()
63+
{
6164
span_lint_and_sugg(
6265
cx,
6366
REDUNDANT_FIELD_NAMES,

tests/ui/redundant_field_names.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,14 @@ fn main() {
6868
let _ = RangeInclusive::new(start, end);
6969
let _ = RangeToInclusive { end: end };
7070
}
71+
72+
fn issue_3476() {
73+
fn foo<T>() {
74+
}
75+
76+
struct S {
77+
foo: fn(),
78+
}
79+
80+
S { foo: foo::<i32> };
81+
}

0 commit comments

Comments
 (0)