Temporarily disable the needless_borrow lint

Author: oli-obk

clippy_lints/src/lib.rs

@@ -592,7 +592,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
         mutex_atomic::MUTEX_ATOMIC,
         needless_bool::BOOL_COMPARISON,
         needless_bool::NEEDLESS_BOOL,
-        needless_borrow::NEEDLESS_BORROW,
         needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
         needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
         needless_update::NEEDLESS_UPDATE,
@@ -771,7 +770,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
         misc_early::ZERO_PREFIXED_LITERAL,
         needless_bool::BOOL_COMPARISON,
         needless_bool::NEEDLESS_BOOL,
-        needless_borrow::NEEDLESS_BORROW,
         needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
         needless_update::NEEDLESS_UPDATE,
         no_effect::NO_EFFECT,
@@ -872,6 +870,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
         attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
         fallible_impl_from::FALLIBLE_IMPL_FROM,
         mutex_atomic::MUTEX_INTEGER,
+        needless_borrow::NEEDLESS_BORROW,
         ranges::RANGE_PLUS_ONE,
     ]);
 }

clippy_lints/src/needless_borrow.rs

@@ -22,7 +22,7 @@ use utils::{in_macro, snippet_opt, span_lint_and_then};
 /// ```
 declare_clippy_lint! {
     pub NEEDLESS_BORROW,
-    complexity,
+    nursery,
     "taking a reference that is going to be automatically dereferenced"
 }
 

tests/run-pass/needless_borrow_fp.rs

@@ -0,0 +1,10 @@
+#[deny(clippy)]
+
+#[derive(Debug)]
+pub enum Error {
+    Type(
+        &'static str,
+    ),
+}
+
+fn main() {}

tests/ui/eta.rs

@@ -1,7 +1,7 @@
 
 
 #![allow(unknown_lints, unused, no_effect, redundant_closure_call, many_single_char_names, needless_pass_by_value)]
-#![warn(redundant_closure)]
+#![warn(redundant_closure, needless_borrow)]
 
 fn main() {
     let a = Some(1u8).map(|a| foo(a));

tests/ui/needless_borrow.rs

@@ -5,7 +5,7 @@ fn x(y: &i32) -> i32 {
     *y
 }
 
-#[warn(clippy)]
+#[warn(clippy, needless_borrow)]
 #[allow(unused_variables)]
 fn main() {
     let a = 5;
@@ -42,7 +42,7 @@ trait Trait {}
 impl<'a> Trait for &'a str {}
 
 fn h(_: &Trait) {}
-
+#[warn(needless_borrow)]
 #[allow(dead_code)]
 fn issue_1432() {
     let mut v = Vec::<String>::new();