Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section on compatibility and subsection on raw identifiers #1095

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Aug 9, 2018

Requirement for rust-lang/rust#53236.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

kennytm added a commit to kennytm/rust that referenced this pull request Aug 11, 2018
…mertj

Stabilise raw_identifiers feature

* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)

Closes rust-lang#48589.

r? @cramertj
CC @cuviper @Centril
kennytm added a commit to kennytm/rust that referenced this pull request Aug 13, 2018
…mertj

Stabilise raw_identifiers feature

* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)

Closes rust-lang#48589.

r? @cramertj
CC @cuviper @Centril
bors added a commit to rust-lang/rust that referenced this pull request Aug 21, 2018
Stabilise raw_identifiers feature

* [Reference PR](rust-lang/reference#395)
* [Book PR](rust-lang/book#1480)
* [Rust by Example PR](rust-lang/rust-by-example#1095)

Closes #48589.

r? @cramertj
CC @cuviper @Centril
@alexreg
Copy link
Contributor Author

alexreg commented Aug 21, 2018

Can we get this merged now that the actual Rust feature has been stabilised? :-)

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read it over, looks good to me, thanks!

@frewsxcv frewsxcv merged commit e0f7ce1 into rust-lang:master Aug 22, 2018
@alexreg
Copy link
Contributor Author

alexreg commented Aug 22, 2018

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants