Add track_env_var to the proc macro server #5651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
changed the title
Merged
|
Perhaps changing the unreachable we hit to be a bit more descriptive makes sense? |
This was referenced Oct 1, 2020
lnicola
force-pushed
the
proc-macro-env
branch
from
7d013d0 to
e82d33b
Compare
lnicola
changed the title
|
r? @matklad |
|
r? @kjeremy 😄 |
|
Do we need to bump the minimum rustc version? |
lnicola
force-pushed
the
proc-macro-env
branch
from
e82d33b to
3d169bd
Compare
|
Okay, CI passes now. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#74653.
Fixes #6054.
Fixes #5640, maybe.
Fixes #5773, hopefully.
Should be merged when 1.47 is released.
Proc macros still don't work for me, but it no longer crashes.