Skip to content

fix: Fixes for dyn inlay hint #20212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Jul 9, 2025

  • Fix their place when there are parentheses.
  • Don't show them for HRTB bounds.

Fixes #20202.

Although frankly, I'd rather rip them from the codebase.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2025
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would you like to have this merged or wait till Lukas is back? I'm just asking as I remember once you said you don't prefer merging PRs by yourself and I'm not sure if you feel uncomfortable if I merge them 😅

@ChayimFriedman2
Copy link
Contributor Author

@ShoyuVanilla I want another pair of eyes. You or @Veykril it doesn't matter (as long as you feel comfortable with your review).

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 10, 2025
Merged via the queue into rust-lang:master with commit eede8f1 Jul 10, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2025
@ChayimFriedman2 ChayimFriedman2 deleted the dyn-hint branch July 10, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-analyzer incorrectly tries to insert dyn in where clause using for<'a> syntax
3 participants