-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: implement attribute completions for diagnostics module #19908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Veykril
merged 4 commits into
rust-lang:master
from
rmehri01:rmehri01/diagnostic_attribute_completions
Jun 6, 2025
Merged
feat: implement attribute completions for diagnostics module #19908
Veykril
merged 4 commits into
rust-lang:master
from
rmehri01:rmehri01/diagnostic_attribute_completions
Jun 6, 2025
+190
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehri01
commented
Jun 2, 2025
8840c3b
to
d49b27b
Compare
d49b27b
to
7e8079f
Compare
Veykril
reviewed
Jun 4, 2025
Veykril
reviewed
Jun 4, 2025
Veykril
reviewed
Jun 4, 2025
Veykril
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll do a small follow up change to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements completions for
diagnostic::on_unimplemented
anddiagnostic::do_not_recommend
. Unless I missed it, I don't think there are other attributes here that deal with qualifiers likediagnostic::
so I added somewhat naive splitting on::
and then made it so that it is stripped before being used in the label and snippet. Similarly, incomplete_known_attribute_input
we first need to check if the qualifier is present instead of assuming thatas_single_name_ref
will work.I also noticed that
must_use
is currently duplicated in functions and traits since it already shows up initem
😄Closes #19892