Skip to content

fix: Properly implement might_be_inside_macro_call() using semantic information instead of syntactical hacks #19864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented May 25, 2025

And rename it to is_inside_macro_call() accordingly.

Should fix #19863.

…rmation instead of syntactical hacks

And rename it to `is_inside_macro_call()` accordingly.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2025
@Veykril Veykril added this pull request to the merge queue May 26, 2025
Merged via the queue into rust-lang:master with commit de4b7b6 May 26, 2025
14 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the is-in-macro branch May 26, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completions not working with Faux macros
3 participants