Skip to content

Conversation

@davidbarsky
Copy link
Contributor

Hi folks! Building on #16394, I've got a few small tweaks:

  • Removed the accidental mod.rs usage that I introduced.
  • Removed a panic in pat_analysis.rs.
  • Recorded the event kind in handle_event to better distinguish what kind of event is being handled.
  • Did a small refactor of hprof to have somewhat more linear control flow, and more importantly, write the recorded fields to the output.

The end result is the following:
A screenshot of Visual Studio Code on a Mac. `hprof.rs` is open, with

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2024
@davidbarsky davidbarsky requested a review from Veykril January 30, 2024 23:23
@davidbarsky
Copy link
Contributor Author

cc: @matklad, who I know was interested in this type of thing.

@Veykril
Copy link
Member

Veykril commented Jan 31, 2024

@bors delegate+

@bors
Copy link
Contributor

bors commented Jan 31, 2024

✌️ @davidbarsky, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@davidbarsky davidbarsky force-pushed the david/tracing-followups branch from 88c1435 to 162a4fa Compare January 31, 2024 18:01
@davidbarsky davidbarsky force-pushed the david/tracing-followups branch from 162a4fa to 44494e2 Compare January 31, 2024 18:16
@davidbarsky
Copy link
Contributor Author

@bors r=@Veykril

@bors
Copy link
Contributor

bors commented Jan 31, 2024

📌 Commit 44494e2 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 31, 2024

⌛ Testing commit 44494e2 with merge 0396811...

@bors
Copy link
Contributor

bors commented Jan 31, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 0396811 to master...

@bors bors merged commit 0396811 into rust-lang:master Jan 31, 2024
@davidbarsky davidbarsky deleted the david/tracing-followups branch February 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants