Skip to content

internal: editor/code: bump minimum version of VS Code to 1.78 #15904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

internal: editor/code: bump minimum version of VS Code to 1.78 #15904

merged 1 commit into from
Nov 15, 2023

Conversation

davidbarsky
Copy link
Contributor

Undoes #15333.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2023
@davidbarsky davidbarsky changed the title editor/code; bump minimum version of VS Code to 1.78 editor/code: bump minimum version of VS Code to 1.78 Nov 15, 2023
lnicola
lnicola reviewed Nov 15, 2023
View reviewed changes
@lnicola lnicola mentioned this pull request Nov 15, 2023
Merged
bors added a commit that referenced this pull request Nov 15, 2023
@bors
Auto merge of #15905 - lnicola:tsconfig, r=lnicola
1d3bf72 
minor: Tweak tsconfig.json

CC #15904
@lnicola
Copy link
Member

lnicola commented Nov 15, 2023 •
edited
Loading

I think you need to do npm update @types/vscode, otherwise you end up updating everything, including tsc to a version that's more strict when parsing its config file.

@davidbarsky
Copy link
Contributor Author

I think you need to do npm update @types/vscode, otherwise you end up updating everything, including tsc to a version that's more strict when parsing its config file.

Cool, yeah—I think this PR was so large because I was futzing around with npm before I realized it was stuck on some DNS stuff. Sorry for the churn.

@lnicola
Copy link
Member

lnicola commented Nov 15, 2023

Might be easier to revert the changes to package-lock.json and start over.

@davidbarsky
Copy link
Contributor Author

Might be easier to revert the changes to package-lock.json and start over.

yeah, already on that. are y'all okay with force pushes?

@davidbarsky davidbarsky force-pushed the davidbarsky/bump-minimum-vscode-version-to-1.78 branch from d13aca4 to df7fa7f Compare November 15, 2023 15:32
@lnicola
Copy link
Member

lnicola commented Nov 15, 2023

Force-pushes and rebases and/or squashes 😛.

@lnicola
Copy link
Member

lnicola commented Nov 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2023

📌 Commit df7fa7f has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 15, 2023

⌛ Testing commit df7fa7f with merge bae9c08...

@davidbarsky
Copy link
Contributor Author

Force-pushes and rebases and/or squashes 😛.

cool! https://sapling-scm.com/ has made me love rebasing for everything and github's lack of a good, rebase-centric workflow bothers me to no end now 😅

@bors
Copy link
Contributor

bors commented Nov 15, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing bae9c08 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Nov 15, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing bae9c08 to master...

@bors bors merged commit bae9c08 into rust-lang:master Nov 15, 2023
@bors
Copy link
Contributor

bors commented Nov 15, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@lnicola lnicola changed the title editor/code: bump minimum version of VS Code to 1.78 internal: editor/code: bump minimum version of VS Code to 1.78 Nov 15, 2023
@davidbarsky davidbarsky deleted the davidbarsky/bump-minimum-vscode-version-to-1.78 branch November 15, 2023 16:17
Wilfred added a commit to Wilfred/rust-analyzer that referenced this pull request Nov 6, 2024
@Wilfred
editors/code: Change minimum VS Code from 1.78 to 1.83
6c7b502 
It's been a year since we last bumped this (see rust-lang#15904), and VS Code
1.83 is the first version that supports LSP 3.17.5 (via
vscode-languageclient 9.0.1).

https://code.visualstudio.com/updates/v1_83#_language-server-protocol
@Wilfred Wilfred mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidbarsky @lnicola @bors @rustbot