Skip to content

minor: hover_simple refactor #15660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2023
Merged

minor: hover_simple refactor #15660

merged 1 commit into from
Sep 24, 2023

Conversation

DaniPopes
Copy link
Contributor

A minor refactor of hover_simple opportunity I noticed while skimming through the code.

  • if lets -> match
  • iter::once(x).cycle -> iter::repeat
  • classify_token -> classify_node

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2023
@HKalbasi
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2023

📌 Commit 588c7d9 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2023

⌛ Testing commit 588c7d9 with merge 862a300...

@bors
Copy link
Contributor

bors commented Sep 24, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 862a300 to master...

@bors bors merged commit 862a300 into rust-lang:master Sep 24, 2023
@DaniPopes DaniPopes deleted the hover-simple-refactor branch September 24, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaniPopes @HKalbasi @bors @rustbot