Add ManifestPath
to CrateData
; update dependency view to use ManifestPath
#14931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've got a few changes:
ManifestPath
toCrateGraph
andproject_json.rs
'sCrate
/CrateData
structs.ManifestPath
is optional inside ofCrateGraph
because single file workspaces don't have a manifest file by definition. I've madeManifestPath
optional inside ofproject_json.rs
for backwards compatibility reasons, but I'd be happy to make it non-optional after a period of time.Cargo.toml
. Since this is is sourced fromCargo
itself, I think this is an overall improvement. It also allows for non-Cargo build systems to make use of this feature.If you're okay with these changes, please let me know before landing it! I'd like to update the documentation for
rust-project.json
with these details (as well as update therust-project
definition in the VS Code extension).