Update to Chalk 88

[detrumi]

This Chalk release introduces fuel for the recursive solver (chalk#774).
I'm not sure how often it calls should_continue compared to the other solver, so we might want to increase CHALK_SOLVER_FUEL, the current default value of 100 might be too low.

This should fix a lot of hangs and crashes, for example this solves the hang in #12897.

[lnicola]

the current default value of 100 might be too low

We run analysis-stats on CI, this appears to yield a small increase in unknown types: https://github.com/rust-lang/rust-analyzer/actions/runs/3622085677/jobs/6106355642 vs. https://github.com/rust-lang/rust-analyzer/actions/runs/3616670546/jobs/6094828214.

[detrumi]

A quick comparison using cargo run --release -p rust-analyzer -- analysis-stats .

master: exprs: 414387, ??ty: 43 (0%), ?ty: 131 (0%), !ty: 1
   100: exprs: 414387, ??ty: 78 (0%), ?ty: 152 (0%), !ty: 5
   500: exprs: 414387, ??ty: 78 (0%), ?ty: 152 (0%), !ty: 5
  1000: exprs: 414387, ??ty: 43 (0%), ?ty: 131 (0%), !ty: 1

So increasing it removes the increase when running it against rust-analyzer itself.

Lowering it might make things faster but also hide existing problems more.
So I think 1000 would be a good value.

[lnicola]

If it's not too much of a hassle, can you also check rust-analyzer analysis-stats --with-deps $(rustc --print sysroot)/lib/rustlib/src/rust/library/std?

[detrumi]

cargo run --release -p rust-analyzer -- analysis-stats --with-deps $(rustc --print sysroot)/lib/rustlib/src/rust/library/std

master: exprs: 421758, ??ty: 42535 (10%), ?ty: 18863 (4%), !ty: 265
   100: exprs: 421758, ??ty: 42555 (10%), ?ty: 18883 (4%), !ty: 267                                                       
  1000: exprs: 421758, ??ty: 42535 (10%), ?ty: 18863 (4%), !ty: 265                                                       

Same story here

[lnicola]

@bors r+

[bors]

📌 Commit a75bffc has been approved by lnicola

It is now in the queue for this repository.

[bors]

⌛ Testing commit a75bffc with merge f9bd487...

[bors]

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing f9bd487 to master...