Skip to content

Ubuntu 21.10 compat #12419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Conversation

KOLANICH
Copy link
Contributor

Yet another backport PR like #9629 (not expected to be merged, is here just to increase its visibility). Makes rust-analyzer buildable on Ubuntu 21.10 impish.

KOLANICH added 16 commits May 30, 2022 19:44
… rustc introduced in some commit in `crates/ide/src/inlay_hints.rs` file
… rustc introduced in some commit in `crates/ide/src/convert_let_else_to_match.rs` file
@KOLANICH KOLANICH force-pushed the ubuntu_21.10_compat branch from 313c420 to e39356e Compare May 30, 2022 16:49
@bjorn3
Copy link
Member

bjorn3 commented May 30, 2022

Looks like you forgot to commit Cargo.lock. Do you plan to close this PR as soon as CI passes or did you intend to keep it open for a bit longer?

@KOLANICH
Copy link
Contributor Author

Looks like you forgot to commit Cargo.lock.

I am a very newbie to Rust, so I don't really know if I should commit it or if it changes because I have messed something wrong (for me diff indicates some packages being added).

Do you plan to close this PR as soon as CI passes

I haven't originally planned to make the CI pass.

or did you intend to keep it open for a bit longer?

TBH can be closed right now. Everyone needing to build it on Ubuntu 21.10 can grab my branch https://github.com/KOLANICH-tools/rust-analyzer/tree/ubuntu_21.10_compat

@KOLANICH KOLANICH closed this May 30, 2022
@lnicola
Copy link
Member

lnicola commented May 30, 2022

I don't have a reference, but I've heard that the rustc distribution available in Debian and presumably Ubuntu are there only to build other packages which need Rust, and not for end-users. You should really be using rustup.

Of course, the other considerations in #9629 (comment) still apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants