This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Commit 968129d
committed
Auto merge of #1244 - Xanewok:translate-tests, r=alexheretic
Translate cmd tests to use async LSP client
This translates our cmd-based tests to use the LSP client introduced in #1223.
Some anecdotal benchmarks (Xubuntu 18.04, Ryzen 2600) before and after translating:
```
$ time cargo test cmd_
real 0m3,498s
user 0m8,379s
sys 0m2,710s
$ time cargo test cmd_ --release
real 0m3,059s
user 0m5,585s
sys 0m2,512s
$ time cargo test client_
real 0m3,465s
user 0m7,197s
sys 0m1,926s
$ time cargo test client_ --release
real 0m3,053s
user 0m4,977s
sys 0m1,825s
```
It seems that synchronization overhead caused by running multiple RLS and rustc instances in-process still outweighs spawning separate processes per test 🎉 That means we don't lose performance (and actually benefit) from switching over.
I plan on translating the remaining tests in tests_old as a separate PR.
r? @alexhereticFile tree
5 files changed
+1104
-1560
lines changed- tests
- support
5 files changed
+1104
-1560
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
0 commit comments