Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Commit 202ce5d

Browse files
committed
Adjust comment on why we strip --error-format
1 parent 8f11693 commit 202ce5d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

rls/src/build/cargo.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,9 @@ impl Executor for RlsExecutor {
391391
_on_stdout_line: &mut dyn FnMut(&str) -> CargoResult<()>,
392392
_on_stderr_line: &mut dyn FnMut(&str) -> CargoResult<()>,
393393
) -> CargoResult<()> {
394-
// Use JSON output so that we can parse the rustc output.
395-
// Filter first to work around "--error-format" being passed with
396-
// CARGO_PIPELINING(?) enabled in Cargo.
394+
// Enforce JSON output so that we can parse the rustc output by
395+
// stripping --error-format if it was specified (e.g. Cargo pipelined
396+
// build)
397397
let filtered_args = filter_arg(cargo_cmd.get_args(), "--error-format");
398398
cargo_cmd.args_replace(&filtered_args);
399399
cargo_cmd.arg("--error-format=json");

0 commit comments

Comments
 (0)