RFC: Inheriting of default-features in Cargo

[epage]

Allow disabling default features locally when inheriting a dependency.

[workspace]

[workspace.dependencies]
serde = "1"

[package]
name = "foo"

[dependencies]
serde = { workspace = true, default-features = false }

Without this RFC, it is an error, see rust-lang/cargo#12162

Important

Since RFCs involve many conversations at once that can be difficult to follow, please use review comment threads on the text changes instead of direct comments on the RFC.

If you don't have a particular section of the RFC to comment on, you can click on the "Comment on this file" button on the top-right corner of the diff, to the right of the "Viewed" checkbox. This will create a separate thread even if others have commented on the file too.

Rendered

[joshtriplett]

This seems reasonable.

Long-term, I hope we have a general mechanism for opting out of specific features that supersedes default-features = false. But short-term, I think this RFC makes sense as proposed, to make default-features = false make more sense with workspace inheritance.

[Muscraft]

Given that this seems pretty straightforward and that multiple Cargo team members have had a chance to review it, I would like to start the FCP process.

@rfcbot fcp merge cargo

[rust-rfcbot]

Team member @Muscraft has proposed to merge this. The next step is review by the rest of the tagged team members:

• @0xPoe
• @Eh2406
• @Muscraft
• @arlosi
• @ehuss
• @epage
• @joshtriplett
• @weihanglo

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[weihanglo]

The changes along the way are so confusing, but at least we work towards a better default.

@rfcbot reviewed
@rust-rfcbot reviewed

(I don't know which works.)

[weihanglo]

No of them works? I need to manually check the box…

[epage]

rfcbot seems to be stuck: #t-infra > rfcbot unresponsive @ 💬

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[ehuss]

Thanks everyone! To track further discussion, subscribe to the tracking issue here: rust-lang/cargo#16959