-
Notifications
You must be signed in to change notification settings - Fork 1.6k
RFC: Safety Tags #3842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zjp-CN
wants to merge
49
commits into
rust-lang:master
Choose a base branch
from
Artisan-Lab:safety-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RFC: Safety Tags #3842
+776
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmcm
reviewed
Jul 31, 2025
scottmcm
reviewed
Jul 31, 2025
juntyr
reviewed
Jul 31, 2025
clarfonthey
reviewed
Jul 31, 2025
danjl1100
reviewed
Jul 31, 2025
Lokathor
reviewed
Aug 1, 2025
error: expected identifier, found keyword `use` --> src/main.rs:2:20 | 2 | #![clippy::safety::use(invariant::ValidPtr)] // 💡 | ^^^ expected identifier, found keyword
kennytm
reviewed
Aug 1, 2025
Co-authored-by: kennytm <kennytm@gmail.com>
ia0
reviewed
Aug 1, 2025
Also * distinguish safety::requires and safety::checked * replace safety::r#use with safety::import * only allow uninhabited enum as tag item
kennytm
reviewed
Aug 5, 2025
This flavor of thing would be nice to introduce more structure (and the possibility for automated tooling) into complex unsafe code bases like |
…ntic granularity
ia0
reviewed
Aug 6, 2025
Open
danjl1100
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the direction this is moving with requires
and checked
since the initial version.
madsmtm
reviewed
Aug 22, 2025
madsmtm
reviewed
Aug 22, 2025
Co-authored-by: Mads Marquart <mads@marquart.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-lang
Relevant to the language team, which will review and decide on the RFC.
T-libs-api
Relevant to the library API team, which will review and decide on the RFC.
T-rustdoc
Relevant to rustdoc team, which will review and decide on the RFC.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This RFC introduces a concise safety-comment convention for unsafe code in standard libraries:
tag every public unsafe function with
#[safety::requires]
and call with#[safety::checked]
.Safety tags refine today’s safety-comment habits: a featherweight syntax that condenses every
requirement into a single, check-off reminder.
The following snippet compiles today if we enable enough nightly features, but we expect Clippy
and Rust-Analyzer to enforce tag checks and provide first-class IDE support.
Rendered