Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2495-min-rust-version.md links #3492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chris-ha458
Copy link

@chris-ha458 chris-ha458 commented Sep 19, 2023

the PR and issue have been updated with different semantics

Rendered

the PR and issue have been updated with different semantics
further field information changes
@ehuss ehuss added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Sep 19, 2023
@ehuss
Copy link
Contributor

ehuss commented Sep 19, 2023

I would lean towards not approving this since we generally have a policy of not updating RFCs after they are merged. Almost all RFCs go through at least some minor changes during the implementation and stabilization phases, and those changes are almost never reflected back into the RFC. The updated information exists in the documentation, and we don't expect RFCs to be a reference source or living documents. They are a snapshot of the decision made at the time it was approved. I would prefer not to give the illusion that the RFC documents are up-to-date, because then we would need to review/change the entire RFC.

EDIT: But thank you for taking a look at trying to update this.

@chris-ha458
Copy link
Author

I understand what you are saying.
Many people still refer the that RFC for as a reference, partially because that is the highest google search result.
I guess this is something we can or should fix by a PR like this.

Just for posterity, at least for MSRV, where would be the de facto reference that is also up to date?
I tried searching for MSRV or Minimum Supported Rust Version in https://doc.rust-lang.org/stable/reference/
but I have not found a satisfactory reference.

Is it expected for users and developers to carefully read through the relevant links and discover the most authoritative data like I have?
I guess that is a reasonable expectation from the developer side, but also I fear that some people might not do the necessary legwork (a pitfall that I initially fell into, and was trying to prevent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants