Change use of "UFCS" to "fully-qualified function call syntax" #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
added
T-lang
Comment on lines
+7
to
+14
| This RFC describes the fully-qualified syntax for making function calls, | ||
| which was previously called Unambiguous or Universal Function Call Syntax | ||
| (UFCS). The [Rust Reference section on call expressions] provides | ||
| an overview of this syntax, and reasons for the change in terminology. | ||
|
|
||
| There are a variety of extensions to allow any method to be used as | ||
| first-class functions. The same extensions also allow for trait methods | ||
| without receivers to be invoked in a more natural fashion. |
There was a problem hiding this comment.
Changing the structure of this entire paragraph doesn't seem necessary to add the explanatory note, and usually RFCs are preserved as close to as-written as reasonable. The intent is good overall with this PR but please favor additive over subtractive changes.
Comment on lines
+73
to
+77
| Another advantage of this proposal is that it implies that all method-calls | ||
| can always be rewritten into an equivalent fully-qualified function call | ||
| (see [RFC 132]). This simplifies the "core language" and makes method dispatch | ||
| notation -- which involves some non-trivial inference -- into a kind of | ||
| "sugar" for the more explicit fully-qualified notation. |
There was a problem hiding this comment.
This looks good, but is there a version that minimizes the diff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3360, this PR updates RFC 132 and RFC 255 to use clearer terminology regarding fully-qualified function call syntax, and links to the relevant section of the Rust Reference.
Rendered