add badge next to github PR and issues

[mustakimali]

This PR updates the generate-book.sh to find all github issue and PR links in the output and add beautiful shields.io badges to show the status (merged/open etc.).

(Note: shields.io has updated to use GitHub's purple color for "closed". The screenshots below have not been updated.)

Open Questions

• Should it replace the text and be a link itself?
• any other type of badges?
• Should it handle github links that are not clickable? example is RFC 2528 - i can give it try if this PR gets approved.
• This currently handles all github issue and PR link (second image above is a PR in mozilla/rust repo) should it be restricted to links in rust-lang/* repos only?
• OR should this script just update the source files (from text/ folder) to bring the changes under source control?

Why?

Being an absolute noob in Rust and due to lack of understanding of the lifecycle of RFCs, I recently spent a lot of time trying to get something working. Just to realise the RFC wasn't incorporated in the language. A badge next to these links would probably make it easier to me to spot this.

Feel free to approve this if you think this will be useful for other. You may also have good reason to not load resources from external site. Thank you either way. 🙏

[calebcartwright]

I think this is an interesting idea, although also speaking as a maintainer of the Shields.io service, I'm wondering if the fact that we still use a red color for closed issues on the badges (GitHub semi-recently switched this to purple) might be problematic in this context give the typical connotations associated with red. I.e. what's the potential for some folks to be confused/misinterpret a red badge as the issue having been rejected/declined/etc.

[mustakimali]

might be problematic in this context give the typical connotations associated with red. I.e. what's the potential for some folks to be confused/misinterpret a red badge as the issue having been rejected/declined/etc.

This is a good point, sheilds.io could match the colour used in github. However in this context, either colour could be a visual cue to for the folks to go and have a look at the issue itself.

It would be great if there was a reliable way to determine if an rfc has been implemented. I see a label B-RFC-approved used but not sure if this gets removed once the work is done.

[calebcartwright]

might be problematic in this context give the typical connotations associated with red. I.e. what's the potential for some folks to be confused/misinterpret a red badge as the issue having been rejected/declined/etc.

This is a good point, sheilds.io could match the colour used in github. However in this context, either colour could be a visual cue to for the folks to go and have a look at the issue itself.

It would be great if there was a reliable way to determine if an rfc has been implemented. I see a label B-RFC-approved used but not sure if this gets removed once the work is done.

badges/shields#7372

[calebcartwright]

Just a heads up that I've updated Shields so probably a good idea to update the screenshots in the description too whenever you get a chance.

https://img.shields.io/github/issues/detail/state/rust-lang/rust/13885

Afterwards it may be worth having this thread of comments hidden since it was a tangential topic that's subsequently been resolved (though will differ that to those with access)

[joshtriplett]

@mustakimali If you can rebase this to apply again, I'd be happy to see it merged.