rfc 0001 process: say "do not force push" changes

[pnkfelix]

As people modify the text of their RFCs, they are sometimes force pushing changes up to github, which can cause the history of previous iterations of the rfc to be lost (which is not so bad), and it also can cause the comment history to be lost on the rfc's ticket (which is much more severe).

See e.g. discussion on PR 10

RFC 0001 should be amended to explicitly advise people to not force push changes to their forks of the rfcs repository when developing an rfc.

[adrientetar]

If people comment of the diff tab and not on the commit itself, this is a non-issue.

[bharrisau]

Is it handy to see the evolution of the RFC? Normally you would rebase and
fast-forward, maybe for this repo it is better to have one commit per
revision?

[pnkfelix]

@adrientetar said "If people comment of the diff tab and not on the commit itself, this is a non-issue."

From the conversation on PR #10, it seems like there are still problems (albeit less severe ones) when you comment on diff's, since outdated diffs collapse their presentation of comments.

[nikomatsakis]

I think it's handy to comment on the commit itself, since you can target a particular section. I also think it's handy to track the various revisions that the RFC went through. And I don't see any value to force-pushing for this particular repository.

[nikomatsakis]

Scratch my last comment; I misunderstood what "comment on the diff" meant.

[adrientetar]

Just not force-pushing should do it otherwise; we shouldn't care about tight history for this repo anyways.

[brson]

Fine by me.

[erickt]

I've filed a bug with GitHub support to ask them to preserve comments during a force push. I'll update this issue if they get back to me.

[steveklabnik]

Comments get preserved (but hidden) on diffs and discussions, it's only if you make a comment on a commit that 'dissapears', and that's because the commit is no longer in the tree.

I don't expect they'll change this behavior, as it's pretty good.

[steveklabnik]

^^^^ click that and you get old comments.

[asb]

@steveklabnik yes, but there is a belief that once those commits are GCed then the comments will be lost too. If a Github person can confirm for sure that doesn't happen, we'd know there's no chance of losing valuable history for RFC discussion.

[pnkfelix]

@steveklabnik also, if I want to search for occurrences of a word/phrase in a long discussion, it doesn't help if I have to go through and click a bunch of "Show outdated diffs" before I search. This was my main complaint in my response to adrien above (see also discussion on PR #10).