Skip to content

Commit b7f346e

Browse files
committed
Addressing some comments on the libstd facade
1 parent ee93546 commit b7f346e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

active/0000-libstd-facade.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ many locations.
8181
#### Strings
8282

8383
In a post-DST world, the string type will actually be a library-defined type,
84-
`Str` (or similarly named). Strings will no longer be a lanuage item or a
84+
`Str` (or similarly named). Strings will no longer be a lanuage feature or a
8585
language-defined type. This implies that any methods on strings must be in the
8686
same crate that defined the `Str` type, or done through extension traits.
8787

@@ -129,7 +129,7 @@ Inclusion of this module is the reason why I/O is included in the module as well
129129
to no overhead required in terms of dependencies.
130130

131131
Neither `print!` nor `format!` macros to be a part of this library, but the
132-
`write!` macro to be present.
132+
`write!` macro would be present.
133133

134134
#### I/O
135135

@@ -397,7 +397,8 @@ various environments seems beneficial.
397397
* Compile times. It's possible that having so many upstream crates for each rust
398398
crate will increase compile times through reading metadata and invoking the
399399
system linker. Would sharding crates still be worth it? Could possible
400-
problems that arise be overcome?
400+
problems that arise be overcome? Would extra monomorphization in all these
401+
crates end up causing more binary bloat?
401402

402403
* Binary bloat. Another possible side effect of having many upstream crates
403404
would be increasing binary bloat of each rust program. Our current linkage

0 commit comments

Comments
 (0)