Skip to content

Commit 700f0ba

Browse files
committed
Removed mention of an optional lint
1 parent 5e4edbf commit 700f0ba

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

active/0000-module-system-cleanup.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
# Summary
88

99
- Lift the hard ordering restriction between `extern crate`, `use` and other items.
10-
- Optionally keep the order restriction as convention with a warn-per-default lint
1110
- Allow `pub extern crate` as opposed to only private ones.
1211
- Allow `extern crate` in blocks/functions, and not just in modules.
1312

@@ -59,7 +58,7 @@ Another use case are item macros/attributes that want to automatically include t
5958
This is possible by having the macro expand to an item that links to the needed crate, eg like this:
6059

6160
```rust
62-
#[MyAttribute]
61+
#[my_attribute]
6362
struct UserType;
6463
```
6564

@@ -75,12 +74,6 @@ With the order restriction still in place, this requires the sub module workarou
7574

7675
As an example, [gfx-rs](https://github.com/gfx-rs/gfx-rs) currently employs this strategy.
7776

78-
## Optionally keeping the order restriction as convention with a warn-per-default lint
79-
80-
It is still useful for developers to know that imports and extern crates are written in certain places,
81-
so it could get weakly enforced with a warn-per-default lint. Macro authors or other users can then simply
82-
disable the lint with an attribute if the need arises.
83-
8477
## Allow `pub extern crate` as opposed to only private ones.
8578

8679
`extern crate` semantically is somewhere between `use`ing a module, and declaring one with `mod`,
@@ -153,9 +146,6 @@ However, as alluded to above it might be a good idea for 1.0 regardless
153146
- If necessary, change resolve to look in the whole scope block for view items, not just in a prefix of it.
154147
- Make `pub extern crate` parse and teach privacy about it
155148
- Allow `extern crate` view items in blocks
156-
- Optionally implement a warn-per-default lint that checks for each item that it is ordered correctly.
157-
Give it a more useful error message like "Convention is to put all imports at the start of the block"
158-
rather than the often confusing "View items need to precede items".
159149

160150
# Drawbacks
161151

0 commit comments

Comments
 (0)