Skip to content

Commit 17f0ef7

Browse files
committed
stdin etc are newtypes; with_output_timeout really wants self
1 parent 2f37b56 commit 17f0ef7

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

text/0517-io-os-reform.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ good shape, modulo a few tweaks:
521521
command to detached mode).
522522

523523
The `stdin`, `stdout`, `stderr` methods will undergo a more
524-
significant change. By default, the corresponding options we be
524+
significant change. By default, the corresponding options will be
525525
considered "unset", the interpretation of which depends on how the
526526
process is launched:
527527

@@ -543,20 +543,18 @@ more general notion of non-child `Process` later on (every
543543
`Child` will be able to give you a `Process`).
544544

545545
* `stdin`, `stdout` and `stderr` will be retained as public fields,
546-
but their types will change to `Box<Reader+Send>` or
547-
`Box<Writer+Send>` as appropriate. This effectively hides the internal
546+
but their types will change to newtyped readers and writers to hide the internal
548547
pipe infrastructure.
549548
* The `kill` method is dropped, and `id` and `signal` will move to `os::platform` extension traits.
550549
* `signal_exit`, `signal_kill`, `wait`, and `forget` will all stay as they are.
551-
* `wait_with_output` will take `&self`.
552550
* `set_timeout` will be changed to use the `with_deadline` infrastructure.
553551

554552
There are also a few other related changes to the module:
555553

556-
* Rename `ProcessOuptput` to `Output`
554+
* Rename `ProcessOutput` to `Output`
557555
* Rename `ProcessExit` to `ExitStatus`, and hide its
558556
representation. Remove `matches_exit_status`, and add a `status`
559-
method yielding an `Option<i32>
557+
method yielding an `Option<i32>`
560558
* Remove `MustDieSignal`, `PleaseExitSignal`.
561559
* Remove `EnvMap` (which should never have been exposed).
562560

0 commit comments

Comments
 (0)