Cleanup error handling #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Update: Cherry picked some cleanup commits over from the other PR. |
anp
approved these changes
May 31, 2018
| @@ -26,6 +26,14 @@ pub const DELAY: u64 = 300; | |||
|
|
|||
| type ParameterMap = BTreeMap<&'static str, String>; | |||
|
|
|||
| macro_rules! params { | |||
There was a problem hiding this comment.
any objection to using https://crates.io/crates/maplit ?
There was a problem hiding this comment.
None :) I added this in #211 just now.
|
Oh also, sorry it took me a bit here, was preparing for and then on a trip out of the country for the last few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the situation in #205 a bit; but not completely yet.