Team nagboard

[brson]

This is to help the teams manage their workflows.

Each team member (rust-lang/Core, compiler, Lang, Libs, tools) gets their own page, like rusty-dash.com/nag/brson. This page shows issues/PRs that require a response.

It supports two types of 'nags':

First, issues written by a team member, with comments containing f? @user @team etc., require feedback. When these comments are created they go onto the mentioned users' nag board. When subsequently the user leaves any comment, the nag is satisfied and it leaves the nag board.

Second, issues written by a team member, containing both the final-comment-period and T-* tag, require a vote. When these comments are created they go onto the nag board of the team members associated with the T-* tag. That user must subsequently leave a comment containing either fcp r+, fcp r- or fcp abstain, after which the nag is cleared.

@dikaiosune This one is higher priority than the other new dashboards we've discussed because it will allow for dev process changes.

ISTM that new nags should also trigger some kind of notification, not just the passive addition to the nag board, but that may be the role of another bot.

cc @nikomatsakis @nrc

[anp]

Sounds great!

1. Is there a machine-readable location of the team hierarchy? It'd be great if every once in a while I could just scrape a source instead of including a configuration file that has to be in sync with Rust governance processes. Could also be useful for other things (maybe?) if it doesn't already exist.
2. Re: notifications -- I think if there's going to be a bot which tallies votes, that'd be a logical place to host notifications. (edit: also, setting up an MTA is a pain and integrating with 3rd party email services is also a pain)

[anp]

@brson Are there any existing examples of these comments from team members? It'd help to have some actual GitHub comments to use for testing as I build this.

[nikomatsakis]

cc @aturon

[brson]

Is there a machine-readable location of the team hierarchy? It'd be great if every once in a while I could just scrape a source instead of including a configuration file that has to be in sync with Rust governance processes. Could also be useful for other things (maybe?) if it doesn't already exist.

I mentioned this on IRC but it's at https://raw.githubusercontent.com/rust-lang/rust-www/master/team.md

@brson Are there any existing examples of these comments from team members? It'd help to have some actual GitHub comments to use for testing as I build this.

No, the f? comments are a new scheme, but syntactically they are the same as the r? comments we already use on pull requests.

[brson]

If you need to test this stuff we can open demo issues and people can leave comments.

[nikomatsakis]

Note that I had not envisioned the bot tallying "votes" -- just tracking who has given feedback and who hasn't. (I don't even think of these as votes per se, since we operate on a consensus plan typically -- more just tracking who has given their opinion and is satisfied with status quo).

[anp]

@nikomatsakis Sure thing. So are the fcp r+ comments not meant for voting? And should I also include in this feature a summary of recent fcp-based nags?

If there's no voting or tallying needed beyond a simple total on the dashboard, I can look at implementing notifications as simply as possible. Email?

[anp]

@brson Some demo issues w/ comments would be fantastic. In my dev database I've got a bunch of issues and comments built, and it's a pretty simple set of criteria for display, but I always prefer to test on "real" data before deploying.

[brson]

@dikaiosune I created some test issues and pinged some people to fill in some comments

[anp]

Great! Hopefully with a quick look at some test data I'll be able to
commit/deploy a first pass tonight.

Adam

On Wed, Jun 22, 2016 at 1:59 PM, Brian Anderson notifications@github.com
wrote:

@dikaiosune https://github.com/dikaiosune I created some test issues
and pinged some people to fill in some comments

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#61 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGfyeXyNeqOxKgr1n-Ukh8spNJptfy0Pks5qOaIxgaJpZM4I4fSg
.

[anp]

Just a heads up that I've been holding on this since @aturon pinged me on #rust-internals on Thursday:

3:29 PM <•aturon> dikaiosune: hi there -- i've been trying to reply on the issue about the "nagboard" but have been crazy busy -- just wanted to say that i think there's a bit more design the teams need to do around exactly how the process should work before we're ready for implementation
3:29 PM <•aturon> dikaiosune: i don't want you to sink too much time into it only to have the requirements change from underneath you