Align pattern destructuring with rest of patterns documentation #1853
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
You're welcome to change the name. We explicitly document that the rule names are not yet stable. |
Previously, `patterns.destructure.placeholder` referred to the `_` in a destructuring pattern as "placeholder" and `..` as "wildcard". This directly contradicted the definition of struct patterns and tuple (struct) patterns, which (indirectly) define `_` as a wildcard pattern and `..` as a structure pattern et cetera (for structs, enums, and union values) or rest pattern (for tuples, tuple structs, slices, and arrays). Update the paragraph to use "wildcard pattern", "et cetera", and "rest pattern" instead. Moreover, add links to their respective sections/statements. Finally, update the rule name to `r[patterns.destructure.wildcard]`.
archer-321
force-pushed
the
fix/1845-wildcard-in-pattern-destructuring
branch
from
188d553 to
7d891f2
Compare
I've renamed the rule identifier to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1845.
Fix the inconsistent use of "wildcard" and "placeholder" in
patterns.destructure.placeholder.Instead of using "placeholder",
_is now referred to as a wildcard pattern, and..is now referred to as an et cetera or rest pattern instead of "wildcard".Moreover, add links to the respective sections/statements to all updated references.
I didn't update the
r[patterns.destructure.placeholder]part, as I imagine doing so would break (external) links to that part of the reference. I can update the commit if this reference should be updated as well.Closes: #1845