-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a prebuilt copy of build-manifest #14
Conversation
6fb4b55
to
b95da75
Compare
b95da75
to
32e731a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me. I am not too happy with constantly re-fetching the whole Rust repository but I don't know that we have better options. I definitely don't want to use github API here, for example, or use the non-rate limited alternatives.
@Mark-Simulacrum oh, to be clear, we're not fetching the whole Rust repository.
|
Hm, I recall seeing a git rev-parse which I wouldn't expect to work in that case. |
I believe this was changed a while ago in rust-lang/promote-release#14.
…k-Simulacrum Update outdated README in build-manifest. I believe this was changed a while ago in rust-lang/promote-release#14.
…k-Simulacrum Update outdated README in build-manifest. I believe this was changed a while ago in rust-lang/promote-release#14.
…k-Simulacrum Update outdated README in build-manifest. I believe this was changed a while ago in rust-lang/promote-release#14.
Rollup merge of rust-lang#126612 - ehuss:build-manifest-readme, r=Mark-Simulacrum Update outdated README in build-manifest. I believe this was changed a while ago in rust-lang/promote-release#14.
Update outdated README in build-manifest. I believe this was changed a while ago in rust-lang/promote-release#14.
This PR changes
promote-release
to use a copy ofbuild-manifest
prebuilt by CI, and stops it from cloningrust-lang/rust
or invoking./x.py
at all when the prebuilt copy is detected. The PR applies the following changes:match
es everywhere.PROMOTE_RELEASE_OVERRIDE_BRANCH
environment variable was replaced withPROMOTE_RELEASE_OVERRIDE_COMMIT
, which gives more flexibility to the person starting the release. Along with that,./run.sh
added support for running a local build with a specific commit.rust-lang/rust
is not needed anymore to detect which commit needs to be released. Instead of updating the repository and looking at the tip of the branch we're interested in,promote-release
now usesgit2
to connect to GitHub and list the refs available on the server, without ever receiving any git object. This is the equivalent ofgit ls-remote
.date
command, since we're depending on it anyway.build-manifest
is now used when available, and on the channels without it the legacy invocation through./x.py
is used instead. This removes the need to clonerust-lang/rust
or invoke the build system at all, speeding up releases.This PR is best reviewed commit-by-commit.
r? @Mark-Simulacrum