Skip to content

fix feature flags #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix feature flags #389

merged 2 commits into from
Feb 9, 2024

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Feb 9, 2024 •
edited
Loading

const_intrinsic_copy stabilization got reverted in rust-lang/rust#117905.

@RalfJung RalfJung changed the title re-add const_intrinsic_copy feature fix feature flags Feb 9, 2024
@RalfJung RalfJung force-pushed the const_intrinsic_copy branch from 9827731 to 45f82c2 Compare February 9, 2024 21:06
@RalfJung
Copy link
Member Author

RalfJung commented Feb 9, 2024

Okay this is painful, we'll need a bunch of careful #[cfg] in the lib.rs that enables exactly the stdarch features needed for each configuration. Enabling features that don't exist for the current target just shows "unknown feature" errors...

@RalfJung RalfJung mentioned this pull request Feb 9, 2024
Merged
@RalfJung RalfJung force-pushed the const_intrinsic_copy branch 3 times, most recently from 6102d87 to 438d26f Compare February 9, 2024 21:18
@RalfJung RalfJung force-pushed the const_intrinsic_copy branch from 438d26f to 047ba0a Compare February 9, 2024 21:20
programmerjake
programmerjake approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@programmerjake programmerjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming it compiles everywhere, lgtm!

@calebzulawski calebzulawski merged commit f505736 into rust-lang:master Feb 9, 2024
@calebzulawski
Copy link
Member

Thanks!

@RalfJung RalfJung mentioned this pull request Feb 11, 2024
Open
@RalfJung RalfJung deleted the const_intrinsic_copy branch March 31, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@programmerjake programmerjake programmerjake approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RalfJung @calebzulawski @programmerjake