Skip to content

Remove default features #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Remove default features #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
920592b
Remove default features
workingjubilee Mar 1, 2022
e00dd30
Adding cfg begins
workingjubilee Mar 1, 2022
da06b80
Attempt to remove cfg?
workingjubilee Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/core_simd/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ categories = ["hardware-support", "no-std"]
license = "MIT OR Apache-2.0"

[features]
default = ["std", "generic_const_exprs"]
default = []
std = []
generic_const_exprs = []

Expand Down
1 change: 0 additions & 1 deletion crates/core_simd/tests/round.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ macro_rules! float_rounding_test {
type Scalar = $scalar;
type IntScalar = $int_scalar;

#[cfg(feature = "std")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these not require std?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is a nuance here in that we don't actually have a target that fully lacks libm support (or equivalent) at the moment, and tests bring in std, so we can't reaaally truly sincerely test for that. For making sure the relevant things work properly (or fail properly), there are some UI tests in the compiler's test suite.

test_helpers::test_lanes! {
fn ceil<const LANES: usize>() {
test_helpers::test_unary_elementwise(
Expand Down
2 changes: 1 addition & 1 deletion crates/std_float/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ edition = "2021"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
core_simd = { path = "../core_simd" }
core_simd = { path = "../core_simd", default-features = false }

[features]
default = ["as_crate"]
Expand Down