Remove default features #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are thoroughly embedded in libcore, we don't need these on by default. Indeed, their presence may provide confusing results during integration attempts.
calebzulawski
approved these changes
Mar 1, 2022
| @@ -9,7 +9,6 @@ macro_rules! float_rounding_test { | |||
| type Scalar = $scalar; | |||
| type IntScalar = $int_scalar; | |||
|
|
|||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
So there is a nuance here in that we don't actually have a target that fully lacks libm support (or equivalent) at the moment, and tests bring in std, so we can't reaaally truly sincerely test for that. For making sure the relevant things work properly (or fail properly), there are some UI tests in the compiler's test suite.
workingjubilee
added a commit
that referenced
this pull request
Jul 19, 2022
Now that we are thoroughly embedded in libcore, we don't need these on by default. Indeed, their presence may provide confusing results during integration attempts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are thoroughly embedded in libcore, we don't need these on by default.
Indeed, their presence may provide confusing results during integration attempts.