Generically implement horizontal min-max

Author: workingjubilee

crates/core_simd/src/reduction.rs

@@ -2,7 +2,7 @@ use crate::simd::intrinsics::{
     simd_reduce_add_ordered, simd_reduce_and, simd_reduce_max, simd_reduce_min,
     simd_reduce_mul_ordered, simd_reduce_or, simd_reduce_xor,
 };
-use crate::simd::{LaneCount, Simd, SupportedLaneCount};
+use crate::simd::{LaneCount, Simd, SimdElement, SupportedLaneCount};
 
 macro_rules! impl_integer_reductions {
     { $scalar:ty } => {
@@ -42,18 +42,6 @@ macro_rules! impl_integer_reductions {
             pub fn horizontal_xor(self) -> $scalar {
                 unsafe { simd_reduce_xor(self) }
             }
-
-            /// Horizontal maximum.  Returns the maximum lane in the vector.
-            #[inline]
-            pub fn horizontal_max(self) -> $scalar {
-                unsafe { simd_reduce_max(self) }
-            }
-
-            /// Horizontal minimum.  Returns the minimum lane in the vector.
-            #[inline]
-            pub fn horizontal_min(self) -> $scalar {
-                unsafe { simd_reduce_min(self) }
-            }
         }
     }
 }
@@ -97,13 +85,22 @@ macro_rules! impl_float_reductions {
                     unsafe { simd_reduce_mul_ordered(self, 1.) }
                 }
             }
+        }
+    }
+}
+
 
+impl<T, const LANES: usize> Simd<T, LANES>
+where
+    T: SimdElement + PartialOrd,
+    LaneCount<LANES>: SupportedLaneCount,
+{
             /// Horizontal maximum.  Returns the maximum lane in the vector.
             ///
             /// Returns values based on equality, so a vector containing both `0.` and `-0.` may
             /// return either.  This function will not return `NaN` unless all lanes are `NaN`.
             #[inline]
-            pub fn horizontal_max(self) -> $scalar {
+            pub fn horizontal_max(self) -> T {
                 unsafe { simd_reduce_max(self) }
             }
 
@@ -112,11 +109,9 @@ macro_rules! impl_float_reductions {
             /// Returns values based on equality, so a vector containing both `0.` and `-0.` may
             /// return either.  This function will not return `NaN` unless all lanes are `NaN`.
             #[inline]
-            pub fn horizontal_min(self) -> $scalar {
+            pub fn horizontal_min(self) -> T {
                 unsafe { simd_reduce_min(self) }
             }
-        }
-    }
 }
 
 impl_float_reductions! { f32 }