Skip to content

Bump byteorder and remove no-op feature #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Bump byteorder and remove no-op feature #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ doctest = false # and no doc tests
required-features = ["rustc_tests"]

[dependencies]
byteorder = { version = "1.1", features = ["i128"] }
cargo_metadata = { version = "0.8", optional = true }
directories = { version = "2.0", optional = true }
rustc_version = { version = "0.2.3", optional = true }
getrandom = { version = "0.1.8", features = ["std"] }
byteorder = "1.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of versions, isn't this a NOP? 1.3 is semver-compatible with 1.1.

Also it is possible that we had to add the feature to make sure we use the exact same feature as other projects in the rustc workspace. So I am not sure that we can just remove it here...

env_logger = "0.6"
log = "0.4"
shell-escape = "0.1.4"
Expand Down