Skip to content

Make sure to sync on file-io.rs tokio test #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2025
Merged

Make sure to sync on file-io.rs tokio test #4370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd20e26
Make sure to sync on file-io.rs tokio test
Noratrieb Jun 1, 2025
bda28aa
tweak comment and use a weaker fence
RalfJung Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/pass-dep/tokio/file-io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ async fn test_create_and_write() -> io::Result<()> {

// Write 10 bytes to the file.
file.write_all(b"some bytes").await?;
// For tokio's file I/O, `await` does not have its usual semantics of waiting until the
// operation is completed, so we have to wait some more to make sure the write is completed.
file.flush().await?;
// Check that 10 bytes have been written.
assert_eq!(file.metadata().await.unwrap().len(), 10);

remove_file(&path).unwrap();
Expand Down