Skip to content

Conversation

@tiif
Copy link
Member

@tiif tiif commented Sep 16, 2024

Fixes #3858

It turned out that the issue mentioned here is the exact cause of ICE.
So in this PR, I changed the type of EpollEventInterest::epfd from i32 to WeakFileDescriptionRef.

@RalfJung RalfJung added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Sep 16, 2024
@tiif
Copy link
Member Author

tiif commented Sep 17, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Sep 17, 2024
@RalfJung
Copy link
Member

Looks good, thanks. :)
r=me after squashing.

@bors delegate+

@bors
Copy link
Contributor

bors commented Sep 17, 2024

✌️ @tiif, you can now approve this pull request!

If @RalfJung told you to "r=me" after making some further change, please make that change, then do @bors r=@RalfJung

@tiif
Copy link
Member Author

tiif commented Sep 17, 2024

@bors r=@RalfJung

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit a690748 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 17, 2024

⌛ Testing commit a690748 with merge bdab169...

@bors
Copy link
Contributor

bors commented Sep 17, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing bdab169 to master...

@bors bors merged commit bdab169 into rust-lang:master Sep 17, 2024
8 checks passed
@tiif tiif deleted the tokiotest branch September 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Waiting for a review to complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

epoll ICE on tokio test

4 participants