Support BCRYPT_RNG_ALG_HANDLE rust-lang/rust#101325 #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saethlin
force-pushed
the
windows-rng
branch
from
a055841
to
ee1c1e6
Compare
|
cc @ChrisDenton @thomcc does this implementation make sense? |
ChrisDenton
approved these changes
Sep 3, 2022
There was a problem hiding this comment.
Yep, this looks right to me. The algorithm must be zero if the BCRYPT_USE_SYSTEM_PREFERRED_RNG flag is set and otherwise the only algorithm we currently use is the one given by the BCRYPT_RNG_ALG_HANDLE pseudo handle.
In the future we may have a fallback that uses BCryptOpenAlgorithmProvider to get an algorithm handle but miri will likely not need to use the fallback code path.
|
@bors r=ChrisDenton |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this on a Windows host, brace for CI...