diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 232628c..5aa9a0e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,18 +54,24 @@ jobs: # One job that "summarizes" the success state of this pipeline. This can then be added to branch # protection, rather than having to add each job separately. + # ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB! success: name: Success runs-on: ubuntu-latest needs: [test-core, test-alloc, test-std, test-simd, test-stdarch] - # Github branch protection is exceedingly silly and treats "jobs skipped because a dependency - # failed" as success. So we have to do some contortions to ensure the job fails if any of its - # dependencies fails. - if: always() # make sure this is never "skipped" + # We need to ensure this job does *not* get skipped if its dependencies fail, + # because a skipped job is considered a success by Github. So we have to + # overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run + # when the workflow is canceled manually. + if: ${{ !cancelled() }} steps: # Manually check the status of all dependencies. `if: failure()` does not work. - name: check if any dependency failed - run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}' + run: | + # Print the dependent jobs to see them in the CI log + jq -C <<< '${{ toJson(needs) }}' + # Check if all jobs that we depend on (in the needs array) were successful. + jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}' # Make a PR to update `rust-version` when the cron job succeeds. # The primary reason for this is that Github stops running our cron job