Deploy {x86_64,aarch64}-unknown-linux-musl binary #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this workflow in my repository and it works as expected: https://github.com/gifnksm/mdBook/releases/tag/test-release |
|
|
ehuss
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Thanks for the PR!
I'm fairly reluctant to add non-tier-1 targets, since there is risk that they will not operate correctly. However, I think the risk for these particular targets is not very high. Just a forewarning that if they cause any issues, they may be removed in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to
.github/workflows/deploy.ymland associated scripts to deploy pre-built binaries forx86_64-unknown-linux-muslandaarch64-unknown-linux-musl.The
x86_64-unknown-linux-muslexecutable is statically linked, so it will work with older versions of glibc or the Alpine Linux container environment.I also added the
aarch64-unknown-linux-muslexecutable because I want mdBook to run in aarch64 Linux environments (using rust-lld as the linker makes cross-compilation easier).This fixes #1779