Syntax highlighting is inconsistent for`editable` code blocks

[mgeisler]

Hi there,

I noticed that the syntax highlighting changes for a Rust code block when it is made editable. The first code block is editable, the second is not:

I guess part of this is because the Ace editor uses a different theme and/or a different syntax highlighting engine.

Would there be interest in changing the default theme for one or the other kind of code block so that the colors match between them?

From a quick skim of the generated HTML, it seems that the syntax highlighting is simpler in the Ace editor compared to the highlighting in non-editable blocks: print! is marked up as a builtin in the non-editable block, but it has no special class in the Ace editor highlighting.

[joaofreires]

They could deprecate the old highlight and fully adopt the Ace editor. Ace has a read-only mode that can be used and standardize highlights.

[mgeisler]

Ace has a read-only mode that can be used and standardize highlights.

Yeah, it would be great to standardize this by using a read-only editor.

However, I'm not sure if the editor supports hiding lines. Perhaps it could be worked around for read-only code blocks: since they're not editable, the hidden lines could even be removed from the generated output.

Doing so would probably imply deprecating/removing the eyeball icon which can be used to toggle the hidden lines. Personally, I would prefer that hidden lines stay hidden since they can often contain strange and unhelpful code which is only there to make the example compile. So I would like an option to not include the eyeball icon in the first place.

[joaofreires]

I think the hiding lines feature could be deprecated. It only works for rust code and after builds, generating incompatibilities between the markdown version and the builded version.

[mgeisler]

I think the hiding lines feature could be deprecated. It only works for rust code and after builds, generating incompatibilities between the markdown version and the builded version.

Deprecating the hidden lines feature would also help solve #1767 which is about editable examples not compiling without a fn main.