Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/llvm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 63f3a1bfcd78355398a460712db25922247756b6
Choose a base ref
...
head repository: rust-lang/llvm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 69ef168544e4f15b793dd35d272008fde9a6e835
Choose a head ref
  • 6 commits
  • 14 files changed
  • 4 contributors

Commits on Feb 20, 2016

  1. Disable the PassInfo cache assertions to make the cache effective in … 

    …builds with assertions enabld

Since the PassInfo cache does a regular, uncached, slow lookup for the
asserted condition, it's not very effective *cough* when assertions are
enabled. Since disabling these assertions gives quite a nice perf boost
and it's not really worse than the patch we had previously, let's just
do that.
    @dotdash @alexcrichton
    dotdash authored and alexcrichton committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    0e9d818 View commit details
    Browse the repository at this point in the history

  2. Add some Rust allocation functions to TargetLibraryInfo + MemoryBuiltins 

    Original patch by Nathaniel Theis
    @alexcrichton
    alexcrichton committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    65cc3e3 View commit details
    Browse the repository at this point in the history

  3. Fix compile on older clang/OSX versions 

    Apparently there's a bug in older clang versions which rejects this code, and
the fix is to just remove the override keyword for now. This is tracked in this
llvm bug:

  https://llvm.org/bugs/show_bug.cgi?id=22619
    @alexcrichton
    alexcrichton committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    d63ac04 View commit details
    Browse the repository at this point in the history

  4. Add support for i1 compare operations to X86 FastISel, and ignore llv… 

    …m.assume()

intrinsics in the target-independent FastISel.
    @pcwalton @alexcrichton
    pcwalton authored and alexcrichton committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    b1639bc View commit details
    Browse the repository at this point in the history

  5. [WinEH] Don't perform state stores in cleanups 

    Our cleanups do not support true lexical nesting of funclets which
obviates the need to perform state stores.

This fixes PR26361.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@259161 91177308-0d34-0410-b5e6-96231b3b80d8
    @majnemer @alexcrichton
    majnemer authored and alexcrichton committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    b9e8f0c View commit details
    Browse the repository at this point in the history

  6. Don't compile usage of std::thread 

    As of the time of this writing it's not actually used anywhere meaningfullly
throughout the LLVM repo that we need, and it unfortunately uses `std::thread`
which isn't available in mingw-w64 toolchains with the win32 threading model
(the one that we use).

Two major changes were made to achieve this:

1. The `ThreadPool.cpp` file was just entirely commented out. This isn't used
   anywhere in the LLVM repo nor in Rust itself.
2. The `ParallelCG.cpp` file was mostly deleted. Unfortunately it's used a few
   places in LLVM and is needed to link correctly, but we in Rust don't use it
   at all. For now it's just a stub implementation that hopefully compiles
   everywhere, but perhaps we can find a less invasive (aka doesn't have rebase
   conflicts in the future) change to apply soon.

For reference, the upstream LLVM bug has been reported [1]

[1]: https://llvm.org/bugs/show_bug.cgi?id=26365
    @alexcrichton
    alexcrichton committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    69ef168 View commit details
    Browse the repository at this point in the history
Loading