Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AsmPrinter and GNU assembler syntax mismatch in the msp430 backend #13

Merged
merged 1 commit into from
May 20, 2019
Merged

Fix AsmPrinter and GNU assembler syntax mismatch in the msp430 backend #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@ void MSP430AsmPrinter::printSrcMemOperand(const MachineInstr *MI, int OpNum,
// Print displacement first

// Imm here is in fact global address - print extra modifier.
if (Disp.isImm() && !Base.getReg())
if (Disp.isImm() && Base.getReg() == MSP430::SR)
O << '&';
printOperand(MI, OpNum+1, O, "nohash");

// Print register base field
if (Base.getReg()) {
if (Base.getReg() != MSP430::SR && Base.getReg() != MSP430::PC) {
O << '(';
printOperand(MI, OpNum, O);
O << ')';
Expand Down
15 changes: 15 additions & 0 deletions llvm/test/CodeGen/MSP430/inline-asm-absolute-addressing.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
; RUN: llc < %s | FileCheck %s

; Check that absolute addressing mode is represented in a way
; defined in MSP430 EABI and not as indexed addressing mode form.
; See PR39993 for details.

target datalayout = "e-p:16:8:8-i8:8:8-i16:8:8-i32:8:8-n8:16"
target triple = "msp430-elf"

define void @f() {
entry:
; CHECK: mov r1, &256
call void asm sideeffect "mov r1, $0", "*m"(i8* inttoptr (i16 256 to i8*))
ret void
}