Skip to content
This repository was archived by the owner on Aug 12, 2021. It is now read-only.

Commit 93ba269

Browse files
committed
Rename fail! to panic!
rust-lang/rfcs#221 The current terminology of "task failure" often causes problems when writing or speaking about code. You often want to talk about the possibility of an operation that returns a Result "failing", but cannot because of the ambiguity with task failure. Instead, you have to speak of "the failing case" or "when the operation does not succeed" or other circumlocutions. Likewise, we use a "Failure" header in rustdoc to describe when operations may fail the task, but it would often be helpful to separate out a section describing the "Err-producing" case. We have been steadily moving away from task failure and toward Result as an error-handling mechanism, so we should optimize our terminology accordingly: Result-producing functions should be easy to describe. To update your code, rename any call to `fail!` to `panic!` instead. Assuming you have not created your own macro named `panic!`, this will work on UNIX based systems: grep -lZR 'fail!' . | xargs -0 -l sed -i -e 's/fail!/panic!/g' You can of course also do this by hand. [breaking-change]
1 parent e4527b0 commit 93ba269

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

terminfo/parm.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ impl FormatOp {
474474
'x' => FormatHex,
475475
'X' => FormatHEX,
476476
's' => FormatString,
477-
_ => fail!("bad FormatOp char")
477+
_ => panic!("bad FormatOp char")
478478
}
479479
}
480480
fn to_char(self) -> char {

0 commit comments

Comments
 (0)