This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Remove unneeded extern core in tgamma
#289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Closed because of #290 |
|
I think this can be merged if you re-open it. You can also fix the CI issues by just allowing the internal features warning. |
|
Alright, I reopened this now. I'll probably close the other PR #290 if weak symbols are a better approach. For the CI errors, I'm assuming it's unrelated to this PR. |
|
CI should be fixed, can you rebase? |
Amanieu
force-pushed
the
remove_unneeded_extern_core
branch
from
f7226ac to
72fdabe
Compare
|
Thanks @Amanieu |
tgross35
pushed a commit
that referenced
this pull request
Apr 18, 2025
Remove unneeded `extern core` in `tgamma`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing some issues when building the crate for different targets that don't have
corebuiltin.