This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Fix sincosf for interval (7*pi/4, 9*pi/4) #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A mistake was made in porting musl's implementation which caused the sin and cos components to be reversed. closes #232
Lokathor
approved these changes
Nov 22, 2019
|
I'm still new as a maintainer so I'll let Alex double check this before it's merged. Either way they'll need to be the one to publish the |
|
Thanks! |
tgross35
pushed a commit
that referenced
this pull request
Apr 18, 2025
A mistake was made in porting musl's implementation which caused the sin and cos components to be reversed. closes #232
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mistake was made in porting musl's implementation which caused the sin
and cos components to be reversed.
closes #232