Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Fix overflow bugs in fma #209

Merged
merged 2 commits into from
Jul 11, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/math/fma.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ pub fn fma(x: f64, y: f64, z: f64) -> f64 {
} else {
/* r -= z */
let t = rlo;
rlo -= zlo;
rhi = rhi - zhi - (t < rlo) as u64;
rlo = rlo.wrapping_sub(zlo);
rhi = rhi.wrapping_sub(zhi.wrapping_sub((t < rlo) as u64));
if (rhi >> 63) != 0 {
rlo = (-(rlo as i64)) as u64;
rhi = (-(rhi as i64)) as u64 - (rlo != 0) as u64;
Expand Down Expand Up @@ -205,3 +205,22 @@ pub fn fma(x: f64, y: f64, z: f64) -> f64 {
}
scalbn(r, e)
}

#[cfg(test)]
mod tests {
use super::*;
#[test]
fn fma_segfault() {
// These two inputs cause fma to segfault on release due to overflow:
assert_eq!(
fma(
-0.0000000000000002220446049250313,
-0.0000000000000002220446049250313,
-0.0000000000000002220446049250313
),
-0.00000000000000022204460492503126,
);

assert_eq!(fma(-0.992, -0.992, -0.992), -0.00793599999988632,);
}
}