Define eventfd on NetBSD #4830
Open
Define eventfd on NetBSD #4830
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
force-pushed
the
netbsd-eventfd
branch
from
f0917cc to
03be810
Compare
JohnTitor
reviewed
Nov 17, 2025
Comment on lines
2206
to
2208
| pub fn eventfd(init: c_uint, flags: c_int) -> c_int; | ||
| pub fn eventfd_read(fd: c_int, value: *mut eventfd_t) -> c_int; | ||
| pub fn eventfd_write(fd: c_int, value: eventfd_t) -> c_int; |
Member
There was a problem hiding this comment.
Any reason that these fn args names don't match with man page?
krobelus
force-pushed
the
netbsd-eventfd
branch
from
03be810 to
2bf5e32
Compare
Collaborator
Contributor
Author
|
+ pub fn eventfd_write(fd: c_int, value: eventfd_t) -> c_int;
Any reason that these fn args names don't match with man page?
I might have copied it from the FreeBSD ones. Fixed
|
Like FreeBSD, NetBSD supports eventfd, see https://man.netbsd.org/eventfd.2. OpenBSD does not AFAICT. While at, it make the already define eventfd* argument names match the respective OSs man pages (or header files).
JohnTitor
force-pushed
the
netbsd-eventfd
branch
from
2bf5e32 to
916a8cf
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like FreeBSD, NetBSD supports eventfd, see
https://man.netbsd.org/eventfd.2.
OpenBSD does not AFAICT.
(for some reason my local rustfmt wants to reformat imports)