Add a lockfile and upgrade dependencies #4534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ctest` is horribly inconsistent across targets for unclear reasons. It seems unlikely, but one possibility is that different versions of dependencies are getting used on different platforms. Attempt to mitigate this by adding a lockfile and upgrading all `Cargo.toml` dependencies to the latest version.
tgross35
added
the
stable-nominated
|
Looks like not a ton of luck improving things here, but there also isn't any harm in being more consistent with our dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctestis horribly inconsistent across targets for unclear reasons. It seems unlikely, but one possibility is that different versions of dependencies are getting used on different platforms. Attempt to mitigate this by adding a lockfile and upgrading allCargo.tomldependencies to the latest version.