Skip to content

Conversation

@Gelbpunkt
Copy link
Contributor

Description

Now that all of the issues with powerpc64 + musl are resolved, let's make sure it won't regress in the future and also build the documentation for it.

This is a tier 2 target for a few months now and requires musl 1.2.3 as a baseline.

The big-endian target isn't tier 2 yet, I'm still working towards that, so we can't test it at the moment.

This obviously depends on all the remaining open pull requests with the fixes.

Sources

https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-2-with-host-tools

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot rustbot added A-CI Area: CI-related items S-waiting-on-review labels Jul 3, 2025
@Gelbpunkt Gelbpunkt force-pushed the ci-docs-powerpc64le-musl branch 2 times, most recently from 6c30ff4 to ef8f6be Compare July 3, 2025 03:19
@tgross35
Copy link
Contributor

tgross35 commented Jul 3, 2025

By the way, are further fixes needed or should this be ready to go? It needs a rebase, but I didn't want to do that in case you were working on it still.

@Gelbpunkt Gelbpunkt force-pushed the ci-docs-powerpc64le-musl branch from ef8f6be to e96e758 Compare July 3, 2025 10:30
@Gelbpunkt
Copy link
Contributor Author

I rebased and addressed the comments, should be ready to go now.

@Gelbpunkt
Copy link
Contributor Author

Hm, verify-build fails on 1.63 since there is no std prebuilt on that version yet AFAICT.

@tgross35
Copy link
Contributor

tgross35 commented Jul 3, 2025

I guess just add it to rust_nightly_linux_targets instead for now, with a note that we can move it when we change the MSRV

@Gelbpunkt Gelbpunkt force-pushed the ci-docs-powerpc64le-musl branch from e96e758 to 32722da Compare July 3, 2025 10:48
@Gelbpunkt
Copy link
Contributor Author

I guess just add it to rust_nightly_linux_targets instead for now, with a note that we can move it when we change the MSRV

Should be done now, I think.

Now that all of the issues with powerpc64 + musl are resolved, let's
make sure it won't regress in the future and also build the
documentation for it.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt Gelbpunkt force-pushed the ci-docs-powerpc64le-musl branch from 32722da to 28ea7a9 Compare July 3, 2025 10:49
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for getting this target fixed up!

@tgross35 tgross35 added this pull request to the merge queue Jul 3, 2025
Merged via the queue into rust-lang:main with commit fd5ca76 Jul 3, 2025
49 of 52 checks passed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jul 29, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
Now that all of the issues with powerpc64 + musl are resolved, let's
make sure it won't regress in the future and also build the
documentation for it.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <rust-lang#4521>)
(cherry picked from commit 28ea7a9)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2025
Now that all of the issues with powerpc64 + musl are resolved, let's
make sure it won't regress in the future and also build the
documentation for it.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <#4521>)
(cherry picked from commit 28ea7a9)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI-related items stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants