Skip to content

Conversation

@Gelbpunkt
Copy link
Contributor

Description

powerpc64 is the only 64-bit target that doesn't use the generic definition for these in musl.

Sources

https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/shm.h#n3

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

powerpc64 is the only 64-bit target that doesn't use the generic
definition for these in musl.

See https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/shm.h#n3

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt
Copy link
Contributor Author

With this, libc-test now fully passes on powerpc64le-unknown-linux-musl. I'll add a PR for testing it in CI momentarily.

@Gelbpunkt
Copy link
Contributor Author

@tgross35 seems like there are labels like O-arm and so on, but none for powerpc, could that perhaps be added?

@tgross35
Copy link
Contributor

tgross35 commented Jul 3, 2025

@tgross35 seems like there are labels like O-arm and so on, but none for powerpc, could that perhaps be added?

Sure, adding the autolabel in #4523

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jul 3, 2025
@tgross35 tgross35 added this pull request to the merge queue Jul 3, 2025
Merged via the queue into rust-lang:main with commit 816b60e Jul 3, 2025
48 of 51 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
powerpc64 is the only 64-bit target that doesn't use the generic
definition for these in musl.

See https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/shm.h#n3

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <rust-lang#4519>)
(cherry picked from commit 1ac2a19)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2025
powerpc64 is the only 64-bit target that doesn't use the generic
definition for these in musl.

See https://git.musl-libc.org/cgit/musl/tree/arch/powerpc64/bits/shm.h#n3

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

(backport <#4519>)
(cherry picked from commit 1ac2a19)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-linux O-musl O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants